Reapply Mac Audit Logs (#19989) after fixing the dependency #20554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the same version the agent is using)
datadog-agent-integrations-bot
bot
added
documentation
dev/testing
dev/tooling
release
qa/skip-qa
iliakur
approved these changes
Jun 19, 2025
github-actions bot
pushed a commit
to vinodkumar-sacumen/integrations-core
that referenced
this pull request
Jun 20, 2025
…ataDog#20554) * Reapply "[AI-5153] DDS: Mac Audit Logs Integration v1.0.0 (DataDog#19989)" (DataDog#20535) This reverts commit a065a24. * Fix dependency (move it to optional dependencies, pin it, and set it to the same version the agent is using) f6efbf3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reapplies the reverted Mac Audit Logs integration first merged here. It fixes the depenency issue that motivated the revert. See 0f5b418 for the fix.
The PR number validation is failing because it expects the number of this PR, however we should probably keep the number of the original PR.
Motivation
The lxml library was set to 5.3.2, which conflicts with the existing lxml 5.1.1 dependency. Also, it wasn't pinned.
This wasn't detected by our CI because it was in the "dependencies" section rather than in the [project.optional-dependencies] section, where it belongs.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged