Emit session_id in XE events as an integer, remove unnecessary event_source field #20559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Always emit session_id as an integer, and remove unnecessary event_source field. The event_source field may be added back, but in the "sqlserver" block in the future, if we decide to make session_name's configurable. The backend is written such that it can handle session_id as an integer or as a string, to maintain backwards compatibility, see https://github.com/DataDog/dd-go/pull/188825
Tested in local dev env.
Session ID now emits as integer:
Motivation
Noticed mismatch of session_id types, and noticed that event_source field was in the wrong layer of the json, and I didn't need it anyhow.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged