Skip to content

Fix metric rounding #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix metric rounding #1570

wants to merge 1 commit into from

Conversation

clairernovotny
Copy link
Member

Summary

  • fix rounding logic in MetricNumeralExtensions
  • remove leftover Debugger.Break from MetricNumeralTests
  • add test for rounding overflowing to next metric prefix

Testing

  • git status --short

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangy hangy

Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clairernovotny @hangy