Specialize 5-arg Hermitian
-Adjoint
multiplication
#1394
+87
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR computes
H::Hermitian * A::Adjoint
as(A' * H)'
. This often ensures that we take BLAS paths. The 2-arg multiplication was already specialized forStridedMatrix{<:BlasFloat }
parents by materializing theAdjoint
, but this PR removes this and specializes the 5-argmul!
instead for generic element types. Even if we don't hit BLAS, the change ensures that we iterate in a cache-friendly manner.However, this PR changes the return type of the 2-arg product from a
Matrix{T}
to anAdjoint{T, Matrix{T}}
On nightly v"1.13.0-DEV.789"
This PR:
In principle, we may copy the result and return a materialized
Matrix
here.Some performance improvements: