-
-
Notifications
You must be signed in to change notification settings - Fork 26
return SVD from pinv(::SVD) #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Whoops, failing because Update: fixed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
- Coverage 93.87% 93.85% -0.02%
==========================================
Files 34 34
Lines 15826 15829 +3
==========================================
+ Hits 14856 14857 +1
- Misses 970 972 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CI failure on Windows is an unrelated server glitch. |
As suggested by @andreasnoack in #1387 (comment), this changes the
pinv(::SVD)
function to instead return the SVD of the pseudo-inverse, rather than an explicit matrix, so that it can be applied stably.(No backwards-compatibility issue since the
pinv(::SVD)
method was introduced in #1387.)