Skip to content

return SVD from pinv(::SVD) #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

return SVD from pinv(::SVD) #1398

wants to merge 9 commits into from

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Jul 2, 2025

As suggested by @andreasnoack in #1387 (comment), this changes the pinv(::SVD) function to instead return the SVD of the pseudo-inverse, rather than an explicit matrix, so that it can be applied stably.

(No backwards-compatibility issue since the pinv(::SVD) method was introduced in #1387.)

@stevengj
Copy link
Member Author

stevengj commented Jul 2, 2025

Whoops, failing because *(::SVD, ::AbstractVector) is not defined. This should be fixed — otherwise returning an SVD object from pinv is useless.

Update: fixed.

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.85%. Comparing base (b7fd696) to head (488bc09).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
- Coverage   93.87%   93.85%   -0.02%     
==========================================
  Files          34       34              
  Lines       15826    15829       +3     
==========================================
+ Hits        14856    14857       +1     
- Misses        970      972       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj
Copy link
Member Author

stevengj commented Jul 4, 2025

CI failure on Windows is an unrelated server glitch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants