You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 15, 2019. It is now read-only.
Whoops, rename _isMounted to _backboneMixinIsMounted, to avoid conflicts
Summary:
Oops, in my last commit, I added an `_isMounted` property to the `BackboneMixin`. Unfortunately, this isn't a super unique name, and some components that use `BackboneMixin` define their //own// `_isMounted` property. `createReactClass` considers this to be an error.
In this change, I rename `BackboneMixin`'s mount-tracking property to `_backboneMixinIsMounted`, to avoid conflicts with other components or mixins.
Test Plan:
In Khan Academy's webapp:
```
tools/tsm-2017-js-codemods/upgrade_js.py
tools/runjstests.py
```
Before this change, this would trigger an error in some dashboard and profile components, warning that the property `_isMounted` is being defined twice. After this change, all tests pass.
Auditors: john
0 commit comments