You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 15, 2019. It is now read-only.
Summary:
Even though this is a mixin, which is already pretty darn deprecated, the new `create-react-class` package gives //extra// warnings about calling `this.isMounted()`.
In this change, we remove `this.isMounted()` from `BackboneMixin`, and reimplement mount state ourselves. This is just as bad, but is a quick way of suppressing the error message that's crashing my unit tests :/
Test Plan:
In the Khan Academy webapp:
```
tools/tsm-2017-js-codemods/upgrade_js.py javascript/projectfeedback-package/projectfeedback-form.jsx
tools/runjstests.py javascript/projectfeedback-package/projectfeedback-form_test.jsx
```
Before this change, this test fails, with a "isMounted is deprecated" error message. After this change, this test passes.
Auditors: john
0 commit comments