-
Notifications
You must be signed in to change notification settings - Fork 5.2k
test: fix failing integration tests #33865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +2 -2)
|
Builds ready [06a8eb6]
UI Startup Metrics (1259 ± 74 ms)
Benchmark value 1092 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1086 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 826 exceeds gate value 800 for chrome browserify home mean firstPaint Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 835 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1382 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1223 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1216 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1218 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 963 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2260 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1740 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1734 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1731 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2677 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2014 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2012 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 320 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 35 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1946 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 294 exceeds gate value 156 for firefox webpack home p95 domInteractive Sum of mean exceeds: 272ms | Sum of p95 exceeds: 738ms Sum of all benchmark exceeds: 1010ms |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist