Skip to content

test: fix failing integration tests #33865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Jun 24, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner June 24, 2025 13:20
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jun 24, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (2 files, +2 -2)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 confirm/
            • 📁 account-selection/
              • 📄 account-selection.tsx +1 -1
            • 📁 splash/
              • 📁 smart-account-update/
                • 📄 smart-account-update.tsx +1 -1

@metamaskbot
Copy link
Collaborator

Builds ready [06a8eb6]
UI Startup Metrics (1259 ± 74 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1259110815177413081382
load109195713527311301223
domContentLoaded108595213467211241216
domInteractive18146081740
firstPaint825115135441711251218
backgroundConnect74121810
firstReactRender20144162037
getState1563272229
initialActions001001
loadScripts834704108570872963
setupStore96354818
WebpackHomeuiStartup22601817281420623602677
load17401353214117818402018
domContentLoaded17341349212317618332014
domInteractive171276131457
firstPaint1756146376217320
backgroundConnect20124062434
firstReactRender22188409111358401
getState144310301331
initialActions316135
loadScripts17311347211117518302011
setupStore187317311924
FirefoxBrowserifyHomeuiStartup13541193175011214121598
load1191105214228512611356
domContentLoaded1190105214228512601356
domInteractive1173552678115320
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313117152252
firstReactRender22194942227
getState11517822835
initialActions001001
loadScripts1171101813978412431329
setupStore74294719
WebpackHomeuiStartup15751338234818316561946
load13621158204915614621608
domContentLoaded13611157204915614621608
domInteractive97324917287294
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23165172542
firstReactRender39294734145
getState124115151031
initialActions002111
loadScripts13421144201715514391584
setupStore9510010821
Benchmark value 1259 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1092 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1086 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 826 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 835 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1382 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1223 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1216 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1218 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 963 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2260 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1740 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1734 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1731 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2677 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2014 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2012 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 320 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 35 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1946 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 294 exceeds gate value 156 for firefox webpack home p95 domInteractive
Sum of mean exceeds: 272ms | Sum of p95 exceeds: 738ms
Sum of all benchmark exceeds: 1010ms

@NidhiKJha NidhiKJha merged commit 4c94a20 into gns-feature-flag-removal Jun 24, 2025
127 of 143 checks passed
@NidhiKJha NidhiKJha deleted the fix-it-tests branch June 24, 2025 19:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants