Make all C# flavors support x-zero-based-enum
and add tables to documentation
#21463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all other C# flavors also support the
x-zero-based-enum
vendor extension and it documents it.Arguably the enums should be some tuple with an actual
value
field so the Java code can have full control, but this will work for now.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)C# Technical Committee
@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha
The build fails on my WSL after about 50 minutes of building on some unrelatated kotlin generator test it seems. I'll try again and I'll update this PR with the outputs if anything.
EDIT: Alright
GlobalSettingsTest
fails because item 345 does not equal test2 but null, but in the dump you get it does appear. Not sure how my changes can break this.