Skip to content

[Components] Support file URLS and file paths in a single prop input #17169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcortes
Copy link
Collaborator

@jcortes jcortes commented Jun 18, 2025

WHY

Resolves #16977

@jcortes jcortes self-assigned this Jun 18, 2025
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2025 11:53am
pipedream-docs ⬜️ Ignored (Inspect) Jun 26, 2025 11:53am
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Jun 26, 2025 11:53am

Copy link
Contributor

coderabbitai bot commented Jun 18, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

67 files out of 174 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jcortes jcortes moved this to Ready for PR Review in Component (Source and Action) Backlog Jun 18, 2025
@jcortes jcortes moved this from Ready for PR Review to Doing in Component (Source and Action) Backlog Jun 18, 2025
@jcortes jcortes force-pushed the improvement-urls-and-file-paths-in-single-prop-input branch 4 times, most recently from 3fa1972 to cd649c0 Compare June 18, 2025 16:47
@jcortes jcortes moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Jun 18, 2025
lcaresia
lcaresia previously approved these changes Jun 18, 2025
@lcaresia lcaresia moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Jun 18, 2025
@jcortes
Copy link
Collaborator Author

jcortes commented Jun 18, 2025

@sergio-eliot-rodriguez @vunguyenhung @dannyroosevelt Once this PR gets merged I will need the following update in the platform:

App Type Removed Replaced By
aws action s3-upload-file.mjs s3-upload-base64-as-file.mjs
aws actions s3-stream-file.mjs, s3-upload-file-tmp.mjs, s3-upload-file-url.mjs s3-upload-files.mjs
digitalocean_spaces action upload-file-tmp.mjs upload-file.mjs
digitalocean_spaces action upload-file-url.mjs upload-file.mjs
cloudflare_api_key action query-worker-analytics.mjs deprecated

Thanks in advance!

@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Jun 19, 2025
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Jun 19, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Components-Support-file-URLS-and-file-paths-in-a-single-prop-input-217bf548bb5e81488eeec498940a8d65

@jcortes jcortes force-pushed the improvement-urls-and-file-paths-in-single-prop-input branch 2 times, most recently from a7720c7 to d808a35 Compare June 24, 2025 21:07
@jcortes
Copy link
Collaborator Author

jcortes commented Jun 24, 2025

Hi @vunguyenhung here are my comments to your last test report!

cloudmersive - Convert To Pdf - Failed

You need to compile the Typscript first then publish!

$ npm run build
$ pd publish ./components/cloudmersive/dist/actions/convert-to-pdf/convert-to-pdf.mjs

## discord - Send Message With File - Failed
### With File URL - Failed
I fixed the issue with FIle Path but this one I couldn't because seems like the discord request function is not exposed publicly in the repo but maybe from the platform it is so I think @dannyroosevelt or @danhsiung I'm gonna need your help here to fix this one!

@jcortes jcortes force-pushed the improvement-urls-and-file-paths-in-single-prop-input branch from d808a35 to bf23731 Compare June 24, 2025 21:13
@jcortes jcortes moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Jun 24, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to Changes Required in Component (Source and Action) Backlog Jun 25, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Components-Support-file-URLS-and-file-paths-in-a-single-prop-input-217bf548bb5e81488eeec498940a8d65

@jcortes jcortes force-pushed the improvement-urls-and-file-paths-in-single-prop-input branch from bf23731 to b4d363a Compare June 25, 2025 15:49
@jcortes
Copy link
Collaborator Author

jcortes commented Jun 25, 2025

Hi @vunguyenhung

deepimage - Auto Enhance - Failed

Can you make sure you are deploying the right version please. I couldn't reproduce any of your reported issues here! Maybe you can increase the version manually and deploy again!

@jcortes jcortes moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Jun 25, 2025
@jcortes jcortes force-pushed the improvement-urls-and-file-paths-in-single-prop-input branch from b4d363a to aaed479 Compare June 25, 2025 15:53
@jcortes jcortes force-pushed the improvement-urls-and-file-paths-in-single-prop-input branch from aaed479 to 81b9005 Compare June 25, 2025 21:25
@vunguyenhung
Copy link
Collaborator

vunguyenhung commented Jun 26, 2025

@jcortes, just to clarify on the DeepImage situation:

  1. You force pushed the app action with version 1.0.0 here: https://github.com/PipedreamHQ/pipedream/compare/master..cd649c0fc64abae424ea60a2619752c100ae13b1#diff-7eb321e1736a0344a92f05721dbcaf0e98466abd5dd225121334fcf0f94846fcR8
  2. When I published this, the latest version of those actions on my account is 1.0.x
  3. Then you force pushed the app version again back to 0.1.0, which is much lower then the existing action version in my account https://github.com/PipedreamHQ/pipedream/pull/17169/files#diff-7eb321e1736a0344a92f05721dbcaf0e98466abd5dd225121334fcf0f94846fcR8
  4. This makes my test workflow basically broken, because I can not publish any action with version 0.1.x going forward. The version needs to be 1.0.x for my account to take effect
  5. For my test workflow, I've been testing similar PRs (for File URL changes) and did not see the version messed up like this

My suggestion:

  • In the future, could you help me to keep the version consistant (only increase)? This will eleminate any confusion about versions in the future

Please let me know any concern you may have. Thanks

Best,
Leo.

@vunguyenhung vunguyenhung moved this from Ready for QA to Ready for Release in Component (Source and Action) Backlog Jun 26, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Components-Support-file-URLS-and-file-paths-in-a-single-prop-input-217bf548bb5e81488eeec498940a8d65

@jcortes
Copy link
Collaborator Author

jcortes commented Jun 26, 2025

@jcortes, just to clarify on the DeepImage situation:

  1. You force pushed the app action with version 1.0.0 here: https://github.com/PipedreamHQ/pipedream/compare/master..cd649c0fc64abae424ea60a2619752c100ae13b1#diff-7eb321e1736a0344a92f05721dbcaf0e98466abd5dd225121334fcf0f94846fcR8
  2. When I published this, the latest version of those actions on my account is 1.0.x
  3. Then you force pushed the app version again back to 0.1.0, which is much lower then the existing action version in my account https://github.com/PipedreamHQ/pipedream/pull/17169/files#diff-7eb321e1736a0344a92f05721dbcaf0e98466abd5dd225121334fcf0f94846fcR8
  4. This makes my test workflow basically broken, because I can not publish any action with version 0.1.x going forward. The version needs to be 1.0.x for my account to take effect
  5. For my test workflow, I've been testing similar PRs (for File URL changes) and did not see the version messed up like this

My suggestion:

  • In the future, could you help me to keep the version consistant (only increase)? This will eleminate any confusion about versions in the future

Please let me know any concern you may have. Thanks

Best, Leo.

Yeah sorry for the confusion here!

@jcortes jcortes force-pushed the improvement-urls-and-file-paths-in-single-prop-input branch from 81b9005 to 660562c Compare June 26, 2025 11:53
@vunguyenhung vunguyenhung moved this from Ready for Release to In QA in Component (Source and Action) Backlog Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Components] Support file URLS and file paths in a single prop input
4 participants