Tettra new components #17264
Tettra new components #17264
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis change introduces a new Tettra app integration along with two actions: "Create Page" and "Suggest Page." It adds modules for API interaction, dynamic property loading, and action execution. The package metadata is updated, and old files are removed or replaced to support the new implementation. Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant CreatePageAction
participant TettraApp
participant TettraAPI
Workflow->>CreatePageAction: Run "Create Page" action with inputs
CreatePageAction->>TettraApp: createPage({ title, body, categoryId, subcategoryId })
TettraApp->>TettraAPI: POST /v1/pages (with page data)
TettraAPI-->>TettraApp: API response (page created)
TettraApp-->>CreatePageAction: Return API response
CreatePageAction-->>Workflow: Output summary and response
sequenceDiagram
participant Workflow
participant SuggestPageAction
participant TettraApp
participant TettraAPI
Workflow->>SuggestPageAction: Run "Suggest Page" action with inputs
SuggestPageAction->>TettraApp: suggestPage({ title, description, categoryId, assignableId })
TettraApp->>TettraAPI: POST /v1/page_suggestions (with suggestion data)
TettraAPI-->>TettraApp: API response (suggestion created)
TettraApp-->>SuggestPageAction: Return API response
SuggestPageAction-->>Workflow: Output summary and response
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/tettra/actions/suggest-page/suggest-page.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/tettra/actions/create-page/create-page.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (4)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
components/tettra/.gitignore(0 hunks)components/tettra/actions/create-page.mjs(1 hunks)components/tettra/actions/suggest-page.mjs(1 hunks)components/tettra/app/tettra.app.ts(0 hunks)components/tettra/package.json(1 hunks)components/tettra/tettra.app.mjs(1 hunks)
💤 Files with no reviewable changes (2)
- components/tettra/.gitignore
- components/tettra/app/tettra.app.ts
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (11)
components/tettra/tettra.app.mjs (3)
1-5: LGTM! Well-structured app module foundation.The import and app structure follow Pipedream conventions correctly with proper type and app identifier definitions.
48-65: LGTM! Well-implemented authentication and request handling.The
_makeRequestmethod correctly handles authentication by adding the API key to the data payload and sets appropriate headers. The use of the team_id in the baseURL follows Tettra's API structure.
66-94: LGTM! API methods are well-structured.All the API methods correctly use the
_makeRequesthelper and follow consistent patterns. The endpoint URLs and HTTP methods align with standard REST conventions.components/tettra/package.json (3)
3-3: LGTM! Appropriate version bump for new functionality.The version bump to 0.1.0 correctly reflects the addition of new action components and the restructured app module.
5-5: LGTM! Correct main entry point update.The main entry point correctly references the new app module structure, removing the build/dist dependency.
15-16: Verify the @pipedream/platform version.Ensure that version ^3.1.0 of @pipedream/platform is stable and contains all the required features for the axios import and app functionality.
What is the latest stable version of @pipedream/platform and are there any known issues with version 3.1.0?components/tettra/actions/create-page.mjs (3)
1-8: LGTM! Well-structured action module.The import, metadata, and basic structure follow Pipedream action conventions correctly. The version and documentation link are appropriate.
27-35: LGTM! Correct implementation of dependent props.The subcategoryId prop correctly uses the categoryId parameter to dynamically load subcategories. The propDefinition pattern is implemented properly.
37-50: LGTM! Proper API call implementation.The run method correctly structures the API call with snake_case field names as expected by the Tettra API. The summary export and response handling are appropriate.
components/tettra/actions/suggest-page.mjs (2)
1-8: LGTM! Well-structured action module.The import, metadata, and basic structure follow Pipedream action conventions correctly.
37-50: LGTM! Proper API call structure and response handling.The run method correctly structures the API call and handles the response appropriately with summary export.
Closes #13278
Summary by CodeRabbit