17296 action get person details pipedrive #17298
Conversation
Actions - Get Person Details
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
""" WalkthroughThis update introduces a new "Get Person Details" action for the Pipedrive integration, enabling retrieval of person details by ID. Supporting this, a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GetPersonDetailsAction
participant PipedriveApp
participant PipedriveAPI
User->>GetPersonDetailsAction: Provide personId
GetPersonDetailsAction->>PipedriveApp: getPerson(personId)
PipedriveApp->>PipedriveAPI: PersonsApi.getPerson(personId)
PipedriveAPI-->>PipedriveApp: Return person details
PipedriveApp-->>GetPersonDetailsAction: Return person details
GetPersonDetailsAction-->>User: Return person details
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
components/pipedrive/actions/search-persons/search-persons.mjs (1)
10-10: Patch-level version increment approvedUpdate to
0.1.12keeps parity with sibling actions. Ensure the rootCHANGELOG(if maintained) also reflects this bump.components/pipedrive/actions/add-deal/add-deal.mjs (1)
8-8: Consistent patch updateVersion moved to
0.1.12, matching other action bumps. Consider adding an automated script to keep versions synchronized in future releases.components/pipedrive/actions/add-note/add-note.mjs (1)
6-9: Fix tiny grammar nit in descriptionThe docstring says “adding an note” – should be “adding a note”.
- description: "Adds a new note. For info on [adding an note in Pipedrive](https://developers.pipedrive.com/docs/api/v1/Notes#addNote)", + description: "Adds a new note. For info on [adding a note in Pipedrive](https://developers.pipedrive.com/docs/api/v1/Notes#addNote)",components/pipedrive/actions/remove-duplicate-notes/remove-duplicate-notes.mjs (1)
8-9: Consider parallelizing note deletions for speedThe sequential
for … await deleteNoteloop (lines 132-134) can be slow for large duplicate sets.
Launching deletions in parallel keeps API rate-limits intact while reducing total runtime.- for (const note of duplicates) { - await this.pipedriveApp.deleteNote(note.duplicate.id); - } + await Promise.all( + duplicates.map(({ duplicate }) => + this.pipedriveApp.deleteNote(duplicate.id) + ), + );Since only the version was bumped, this is optional, but worth considering before the next release.
Also applies to: 128-135
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (19)
components/pipedrive/actions/add-activity/add-activity.mjs(1 hunks)components/pipedrive/actions/add-deal/add-deal.mjs(1 hunks)components/pipedrive/actions/add-lead/add-lead.mjs(1 hunks)components/pipedrive/actions/add-note/add-note.mjs(1 hunks)components/pipedrive/actions/add-organization/add-organization.mjs(1 hunks)components/pipedrive/actions/add-person/add-person.mjs(1 hunks)components/pipedrive/actions/get-person-details/get-person-details.mjs(1 hunks)components/pipedrive/actions/remove-duplicate-notes/remove-duplicate-notes.mjs(1 hunks)components/pipedrive/actions/search-notes/search-notes.mjs(1 hunks)components/pipedrive/actions/search-persons/search-persons.mjs(1 hunks)components/pipedrive/actions/update-deal/update-deal.mjs(1 hunks)components/pipedrive/actions/update-person/update-person.mjs(1 hunks)components/pipedrive/package.json(1 hunks)components/pipedrive/pipedrive.app.mjs(1 hunks)components/pipedrive/sources/new-deal-instant/new-deal-instant.mjs(1 hunks)components/pipedrive/sources/new-person-instant/new-person-instant.mjs(1 hunks)components/pipedrive/sources/updated-deal-instant/updated-deal-instant.mjs(1 hunks)components/pipedrive/sources/updated-lead-instant/updated-lead-instant.mjs(1 hunks)components/pipedrive/sources/updated-person-instant/updated-person-instant.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
🔇 Additional comments (17)
components/pipedrive/pipedrive.app.mjs (1)
446-451: LGTM! Well-implemented method following established patterns.The
getPersonmethod is correctly implemented and consistent with other person-related methods in the file:
- Uses PersonsApi v2 (same as
getPersons,addPerson,updatePerson)- Follows the established parameter structure with
idfield- Returns the API response directly as expected
components/pipedrive/package.json (1)
3-3: Appropriate version increment for new functionality.The version bump from 0.7.0 to 0.7.1 correctly reflects the addition of new functionality (getPerson method and get-person-details action).
components/pipedrive/actions/add-activity/add-activity.mjs (1)
10-10: Routine version increment.Version bump from 0.1.11 to 0.1.12 is appropriate and consistent with the package-wide version updates.
components/pipedrive/actions/add-organization/add-organization.mjs (1)
8-8: Routine version increment.Version bump from 0.1.11 to 0.1.12 is appropriate and consistent with the coordinated version updates across Pipedrive actions.
components/pipedrive/actions/add-person/add-person.mjs (1)
9-9: Routine version increment.Version bump from 0.1.11 to 0.1.12 maintains consistency with the package-wide version updates.
components/pipedrive/sources/updated-lead-instant/updated-lead-instant.mjs (1)
10-10: Version bump looks goodMinor bump from
0.1.0→0.1.1is consistent with other components in this PR and communicates a patch-level, non-breaking change.
No further action needed.components/pipedrive/actions/add-lead/add-lead.mjs (1)
9-9: Aligned version bump
0.0.6correctly signals a backward-compatible enhancement. No code changes detected beyond the metadata.components/pipedrive/sources/updated-person-instant/updated-person-instant.mjs (1)
10-10: Version metadata updated
0.1.1mirrors the lead source change—LGTM.components/pipedrive/actions/update-deal/update-deal.mjs (1)
8-9: Version bump looks goodNo functional changes were introduced; the minor patch increment keeps semantic-versioning consistency with the other actions in this PR.
components/pipedrive/sources/new-person-instant/new-person-instant.mjs (1)
9-10: Version bump acknowledgedPatch version increment only – no concerns.
components/pipedrive/actions/search-notes/search-notes.mjs (1)
7-8: Version bump approvedNo behaviour change detected; aligns with the suite-wide patch updates.
components/pipedrive/actions/update-person/update-person.mjs (1)
9-9: LGTM: Standard version increment.Version bump is appropriate for coordinated package release.
components/pipedrive/sources/new-deal-instant/new-deal-instant.mjs (1)
9-9: LGTM: Standard version increment.Version bump is appropriate for coordinated package release.
components/pipedrive/sources/updated-deal-instant/updated-deal-instant.mjs (1)
10-10: LGTM: Standard version increment.Version bump is appropriate for coordinated package release.
components/pipedrive/actions/get-person-details/get-person-details.mjs (3)
1-3: LGTM: Clean imports.Appropriate imports for error handling and app integration.
4-20: LGTM: Well-structured action definition.The action metadata, props definition, and propDefinition usage follow Pipedream best practices correctly.
21-33: Verify getPerson method exists in pipedrive app.The implementation follows standard patterns, but ensure the
getPersonmethod is properly implemented in the Pipedrive app module.#!/bin/bash # Description: Verify that getPerson method exists in the Pipedrive app # Expected: Find the getPerson method implementation # Search for getPerson method in the pipedrive app file ast-grep --pattern 'getPerson($_) { $$$ }' # Also search for any getPerson references rg -A 5 "getPerson"
There was a problem hiding this comment.
Hi @luancazarine lgtm! Just added a minor version change! Ready for QA!
Co-authored-by: Jorge Cortes <jacortesmahmud@gmail.com>
|
/approve |
Resolves #17296
Summary by CodeRabbit
New Features
Chores