Skip to content

fix(router-devtools-core): make solid-js a dependency #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

SeanCassiere
Copy link
Member

@SeanCassiere SeanCassiere commented Jun 13, 2025

Stemming from issues in #4376.

This change makes it so that solid-js is a core dependency of router-devtools-core instead of just being a devDependency. As such, its consumers (i.e react-router-devtools and solid-router-devtools) shouldn't need to have solid-js be a core dependency it their packages.

Tested using the pr.pkg.new packages using the following package managers:

  • pnpm (10.11.0)
  • npm (10.9.2)
  • yarn (1.22.22)
  • bun (1.2.15) - pr.pkg.new packages for whatever reason outright have issues during installs that don't seem to be related to this dependency.

Edit: After the production release, I retested this change using bun and it worked.

Copy link

nx-cloud bot commented Jun 13, 2025

View your CI Pipeline Execution ↗ for commit 665c160.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 4m 57s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 28s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-13 07:43:28 UTC

Copy link

pkg-pr-new bot commented Jun 13, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4412

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4412

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4412

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4412

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4412

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4412

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4412

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4412

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4412

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4412

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4412

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4412

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4412

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4412

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4412

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4412

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4412

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4412

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4412

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4412

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4412

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4412

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4412

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4412

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4412

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4412

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4412

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4412

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4412

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4412

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4412

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4412

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4412

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4412

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4412

commit: 665c160

@SeanCassiere SeanCassiere marked this pull request as ready for review June 13, 2025 07:47
@SeanCassiere SeanCassiere merged commit bac5032 into main Jun 13, 2025
5 checks passed
@SeanCassiere SeanCassiere deleted the devtools-add-solid-dep branch June 13, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant