Adjustment external views #51889
Open
Adjustment external views #51889
+411
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
ryanahamilton,
jscheffl,
shubhamraj-git,
bugraoz93,
kaxil,
potiuk,
ephraimbuddy,
rawwar and
jason810496
as code owners
boring-cyborg
bot
added
area:airflow-ctl
area:API
|
Second commit looks weird, (pre-commit hook formatting for generated files). Fixed in: #51890 |
pierrejeambrun
force-pushed
the
51855-update-iframe-views
branch
2 times, most recently
from
4c79e8e to
74dfc89
Compare
hussein-awala
approved these changes
Jun 18, 2025
bugraoz93
approved these changes
Jun 18, 2025
bbovenzi
reviewed
Jun 18, 2025
| # Optional parameters, relative URL location for the iframe rendering. If not provided, external view will be rendeded as an external link. Shouldn | ||
| # not contain a leading slash. | ||
| "url_route": "my_iframe_view", | ||
| # Optional category, only relevant for destination "nav". This is used to group the external links in the navigation bar. |
There was a problem hiding this comment.
Suggested change
| # Optional category, only relevant for destination "nav". This is used to group the external links in the navigation bar. | |
| # Optional category, only relevant for destination "nav". This is used to group the external links in the navigation bar. We will match the existing menus of ["browse", "docs", "admin", "user"] and if there's no match then create a new menu |
bbovenzi
reviewed
Jun 18, 2025
pierrejeambrun
force-pushed
the
51855-update-iframe-views
branch
from
74dfc89 to
06d88e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #51855