HIVE-28790: ACID deletes are failing with ArrayIndexOutOfBoundsExcept… #5901
+76
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests pending
tests unstable
labels
|
cc @zhangbutao |
|
I'm following this PR. :) |
deniskuzZ
reviewed
Jun 27, 2025
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 27, 2025
deniskuzZ
reviewed
Jun 27, 2025
deniskuzZ
reviewed
Jun 27, 2025
deniskuzZ
reviewed
Jun 27, 2025
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
…ion when direct insert is enabled
deniskuzZ
approved these changes
Jul 1, 2025
There was a problem hiding this comment.
+1, pending tests
@kokila-19 please cherry-pick the fix into branch-4.1, once this PR is merged
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
kokila-19
added a commit
to kokila-19/hive
that referenced
this pull request
Jul 3, 2025
…ion when direct insert is enabled (apache#5901) (cherry picked from commit 280c1fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion when direct insert is enabled
What changes were proposed in this pull request?
If the length of outPathsCommitted array is shorter than the writeroffset, then extend the outPathsCommitted array to the length of writeroffset + 1
Why are the changes needed?
The problem is in the FileSinkOperator.createDynamicBucket method:
Acid deletes will fail with ArrayIndexOutOfBoundException when closing the writes, because the size of the array is not compared with the writerOffsetbecause and there is a possibility that the outPathsCommitted array is shorter than the updaters array.
Does this PR introduce any user-facing change?
No
How was this patch tested?
qtest