Skip to content

Move project mutation inside project lock #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Move project mutation inside project lock #2474

merged 1 commit into from
Jun 12, 2025

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jun 12, 2025 •
edited
Loading

Move method into lock scope as it is mutating MavenProject instance.
This ensures that instance mutation happens by single caller.

Fixes #2455

@cstamas
Forward port of 2455 fix
a81e3dd 
This is just a forward port of bugfix from
3.9.x

Fixed apache#2455
@cstamas cstamas requested a review from gnodet June 12, 2025 12:53
@cstamas cstamas added the bug Something isn't working label Jun 12, 2025
@cstamas cstamas added this to the 4.0.0-rc-4 milestone Jun 12, 2025
@gnodet gnodet changed the title Forward port of 2455 fix Forward port of #2455 fix Jun 12, 2025
gnodet
gnodet reviewed Jun 12, 2025
View reviewed changes
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a descriptive commit message, not only a reference to the other fix.

@cstamas cstamas changed the title Forward port of #2455 fix Move project mutation inside project lock #2455 fix Jun 12, 2025
@cstamas cstamas changed the title Move project mutation inside project lock #2455 fix Move project mutation inside project lock Jun 12, 2025
@cstamas cstamas marked this pull request as ready for review June 12, 2025 14:54
@gnodet gnodet merged commit b54c742 into apache:master Jun 12, 2025
19 checks passed
@cstamas cstamas deleted the issue-2455 branch June 12, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet gnodet left review comments

Assignees

@gnodet gnodet

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.0-rc-4
Development

Successfully merging this pull request may close these issues.

Maven 3.9.10 fails randomly with message: Cannot evaluate expression '${project.artifactMap}'
2 participants
@cstamas @gnodet