Skip to content

Add API endpoint suitable for dput. #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benallard
Copy link

Fixes #

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx
Copy link
Member

neolynx commented Apr 12, 2025

looks good !

could you please add a description for the PR, maybe with an example on how to use it?

In order to merge, we should add a system test and make sure we have good test coverage. Maybe you can have a look at existing tests, and copy and modify one...

the test seem to fail in the pipeline, due to a go version conflict. I will look at this soonish...

@neolynx
Copy link
Member

neolynx commented Apr 25, 2025

Hi and thanks a lot for this feature !

I tried to rebase on master, but don't have the permissions on your repo. could you somehow share the PR or rebase ?

The system tests should be working again on master...

@neolynx neolynx added the needs rebase The PR needs to be rebased on master label Apr 26, 2025
@neolynx neolynx added the help wanted ! Please help getting this PR merged :-) label May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted ! Please help getting this PR merged :-) needs rebase The PR needs to be rebased on master needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants