Skip to content

Support for Multiple Custom Domains #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Support for Multiple Custom Domains #1258

wants to merge 14 commits into from

Conversation

duedares-rvj
Copy link
Member

@duedares-rvj duedares-rvj commented May 27, 2025

🔧 Changes

  1. resource/auth0_custom_domain: Instead of returning only the default and singular custom_domain present for the domain, the data_source now takes custom_domain_id as input and fetches details for the same.
  2. data_source/auth0_custom_domain: Added support to set domain_metadata and retrieve read-only fields like verification and certificate
resource "auth0_custom_domain" "my_custom_domain" {
  domain     = "domain.auth.tempdomain.com"
  type       = "auth0_managed_certs"
  tls_policy = "recommended"
  domain_metadata = {
    key1 : "value1"
    key2 : "value2"
  }
}
data "auth0_custom_domain" "test" {
  custom_domain_id = auth0_custom_domain.my_custom_domain.id
}

📚 References

🔬 Testing

Updated and re-recorded all relevant test-cases.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj marked this pull request as ready for review May 30, 2025 06:54
@duedares-rvj duedares-rvj requested a review from a team as a code owner May 30, 2025 06:54
@kushalshit27 kushalshit27 requested a review from Copilot June 2, 2025 04:08
Copilot

This comment was marked as resolved.

go.mod Outdated
@@ -6,7 +6,7 @@ toolchain go1.23.7

require (
github.com/PuerkitoBio/rehttp v1.4.0
github.com/auth0/go-auth0 v1.21.0
github.com/auth0/go-auth0 v1.21.1-0.20250529025026-5323fb5cf4a3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to go-auth0 released version before merge

kushalshit27
kushalshit27 previously approved these changes Jun 2, 2025
Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@duedares-rvj duedares-rvj self-assigned this Jun 11, 2025
@kushalshit27 kushalshit27 requested a review from Copilot June 12, 2025 07:18
Copilot

This comment was marked as outdated.

Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it breaking change for existing users if they update the provider ?

@kushalshit27 kushalshit27 self-requested a review June 12, 2025 07:22
@duedares-rvj
Copy link
Member Author

duedares-rvj commented Jun 13, 2025

Is it breaking change for existing users if they update the provider ?

Yeah, that was a major concern we had while implementation. But I believe we have handled all cases to ensure there is no breaking change on existing customer. Let me know if you find any flow where it might be of an impact. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants