-
Notifications
You must be signed in to change notification settings - Fork 96
Support for Multiple Custom Domains #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
go.mod
Outdated
@@ -6,7 +6,7 @@ toolchain go1.23.7 | |||
|
|||
require ( | |||
github.com/PuerkitoBio/rehttp v1.4.0 | |||
github.com/auth0/go-auth0 v1.21.0 | |||
github.com/auth0/go-auth0 v1.21.1-0.20250529025026-5323fb5cf4a3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to go-auth0 released version before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it breaking change for existing users if they update the provider ?
Yeah, that was a major concern we had while implementation. But I believe we have handled all cases to ensure there is no breaking change on existing customer. Let me know if you find any flow where it might be of an impact. Thanks! |
🔧 Changes
resource/auth0_custom_domain
: Instead of returning only the default and singularcustom_domain
present for the domain, the data_source now takescustom_domain_id
as input and fetches details for the same.data_source/auth0_custom_domain
: Added support to setdomain_metadata
and retrieve read-only fields likeverification
andcertificate
📚 References
🔬 Testing
Updated and re-recorded all relevant test-cases.
📝 Checklist