Skip to content

refactor: remove mode from theme #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented May 14, 2025

Changes

The main purpose of this PR is removing the concept of theme modes (adaptive and exact) that were previously used to control how dark theme was applied. This simplifies the theming system by removing this additional layer of complexity, making the dark theme behavior more straightforward and consistent.

  1. Documentation Changes:
  • Removed documentation about dark theme modes (adaptive and exact) from the theming guide
  • Removed references to dark theme mode in component documentation
  1. Theme Changes:
  • Removed mode: 'adaptive' from theme
  • Removed mode-related theme overrides from example components
  1. Card Component:
  • Removed dark adaptive mode logic and animations
  • Simplified elevation animation to use a single animated value

@lukewalczak lukewalczak added the v6 label May 14, 2025
Copy link

The mobile version of example app from this branch is ready! You can see it here.

@callstack-bot
Copy link

callstack-bot commented May 14, 2025

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak lukewalczak marked this pull request as ready for review May 14, 2025 19:50
@lukewalczak lukewalczak force-pushed the refactor/remove-mode-from-theme branch from 0a58c3a to 8aabe1e Compare May 15, 2025 12:23
@lukewalczak lukewalczak force-pushed the refactor/remove-mode-from-theme branch from 8aabe1e to 3d80712 Compare May 20, 2025 14:14
@lukewalczak lukewalczak force-pushed the refactor/remove-mode-from-theme branch from 3d80712 to 86e77ab Compare May 21, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants