Update template-literals.md #3290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
(This is related to the discussion #3277 )
Currently, these docs mention that template literals are an alternative to object literals but there are actually no docs for setting up object literals except for the styled components migration docs.
In my opinion, styled components and emotion have supported object literals for so many years that the two approaches go hand in hand. And so I think it makes sense to point out how to set up both, independently from the migration section. Especially since I would argue that this process is more straightforward if one already has a basic panda setup.
(I felt it would be best to just show a WIP like this. I understand that if this was merged as is, it might not look pretty in the sidebar. Or maybe you think that this should be structured/done differently.)