Skip to content

fix: skipping vacuum inside explicit transaction #18228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Jun 23, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Skipping vacuum inside explicit transaction

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jun 23, 2025
Copy link
Contributor

🤖 Smart Auto-retry Analysis

Workflow Run: 15825768808

The workflow run has been analyzed for retryable errors using job annotations.


📊 Analysis Summary

Metric Count
Total Failed/Cancelled Jobs 2
Jobs with Retryable Errors 2
Jobs with Code/Test Issues 0

✅ Retry Status: AUTOMATIC RETRY INITIATED

2 job(s) have been automatically retried due to infrastructure issues detected in annotations:

  • Runner communication failures
  • Network timeouts
  • Resource exhaustion
  • Other transient infrastructure problems

📈 Monitor Progress: View in Actions


🔍 Detailed Job Analysis

🔄 linux / test_unit

Status:Retryable (Infrastructure Issue)
Reason: Infrastructure issue detected
Annotations: 1 found

🔄 linux / build (x86_64, X64)

Status:Retryable (Infrastructure Issue)
Reason: Infrastructure issue detected
Annotations: 1 found


🤖 About This Analysis

This is an automated analysis and retry triggered by the smart retry workflow using job annotations. The system analyzes failure patterns to distinguish between:

  • 🔄 Infrastructure Issues: Runner failures, network timeouts, resource exhaustion
  • ❌ Code/Test Issues: Compilation errors, test failures, logic problems

Only infrastructure issues are automatically retried to avoid wasting resources on code problems that need manual fixes.

Copy link
Contributor

🤖 Smart Auto-retry Analysis

Workflow Run: 15825768808

The workflow run has been analyzed for retryable errors using job annotations.


📊 Analysis Summary

Metric Count
Total Failed/Cancelled Jobs 1
Jobs with Retryable Errors 1
Jobs with Code/Test Issues 0

✅ Retry Status: AUTOMATIC RETRY INITIATED

1 job(s) have been automatically retried due to infrastructure issues detected in annotations:

  • Runner communication failures
  • Network timeouts
  • Resource exhaustion
  • Other transient infrastructure problems

📈 Monitor Progress: View in Actions


🔍 Detailed Job Analysis

🔄 linux / build (x86_64, X64)

Status:Retryable (Infrastructure Issue)
Reason: Infrastructure issue detected
Annotations: 1 found


🤖 About This Analysis

This is an automated analysis and retry triggered by the smart retry workflow using job annotations. The system analyzes failure patterns to distinguish between:

  • 🔄 Infrastructure Issues: Runner failures, network timeouts, resource exhaustion
  • ❌ Code/Test Issues: Compilation errors, test failures, logic problems

Only infrastructure issues are automatically retried to avoid wasting resources on code problems that need manual fixes.

@databendlabs databendlabs deleted a comment from github-actions bot Jun 26, 2025
@databendlabs databendlabs deleted a comment from github-actions bot Jun 26, 2025
@databendlabs databendlabs deleted a comment from github-actions bot Jun 26, 2025
@databendlabs databendlabs deleted a comment from github-actions bot Jun 26, 2025
@dantengsky dantengsky marked this pull request as ready for review June 30, 2025 01:57
@dantengsky dantengsky requested a review from SkyFan2002 June 30, 2025 01:57
@SkyFan2002 SkyFan2002 merged commit b9f2227 into databendlabs:main Jun 30, 2025
248 of 261 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants