Rework terminal settings #1585
Open
Rework terminal settings #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts fixed: # src/Widgets/Terminal.vala
zeebok
reviewed
Jul 14, 2025
src/Widgets/Terminal.vala
Outdated
| @@ -233,7 +321,7 @@ public class Code.Terminal : Gtk.Box { | |||
| return Gdk.EVENT_PROPAGATE; | |||
| } | |||
|
|
|||
| if (CONTROL_MASK in modifiers && pantheon_terminal_settings.get_boolean ("natural-copy-paste")) { | |||
| if (CONTROL_MASK in modifiers && terminal_settings.get_boolean ("natural-copy-paste")) { | |||
There was a problem hiding this comment.
Should we check for terminal_setting == null here?
There was a problem hiding this comment.
Ah yes! Thanks for spotting that.
* Handle Shift-Control copy-paste anyway
|
Now implements Shift-Control modified copy-paste keys in absence of terminal settings (the Vte widget does not so cannot just propagate). This follows Terminal app behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1586
Fixes #276
The behaviour with regard to Terminal/System style settings is unchanged - this will be addressed in a separate PR.
The Terminal pane only responds to changes in the Terminal "foreground", "background" and "palette" keys but not "window-style" or "cursor-color".