Animated: Trigger Callback on Stopping Native Loops #52274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77329013 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Jun 25, 2025
Summary: Currently, `callback` in `Animated.loop(animation).start(callback)` does not get triggered when calling `stop()` if `animation` uses native driver. This diff implements that functionality. Changelog: [General][Changed] - Stopping an `Animated.loop` for a native animation will now correctly trigger completion callbacks supplied to `start()`. Differential Revision: D77329013
yungsters
force-pushed
the
export-D77329013
branch
from
0601868 to
d8b66c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77329013 |
yungsters
force-pushed
the
export-D77329013
branch
from
d8b66c6 to
0a6aca9
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Jun 26, 2025
Summary: Currently, `callback` in `Animated.loop(animation).start(callback)` does not get triggered when calling `stop()` if `animation` uses native driver. This diff implements that functionality. Changelog: [General][Changed] - Stopping an `Animated.loop` for a native animation will now correctly trigger completion callbacks supplied to `start()`. Differential Revision: D77329013
|
This pull request was exported from Phabricator. Differential Revision: D77329013 |
yungsters
force-pushed
the
export-D77329013
branch
from
0a6aca9 to
38049e0
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Jun 26, 2025
Summary: Pull Request resolved: facebook#52274 Currently, `callback` in `Animated.loop(animation).start(callback)` does not get triggered when calling `stop()` if `animation` uses native driver. This diff implements that functionality. Changelog: [General][Changed] - Stopping an `Animated.loop` for a native animation will now correctly trigger completion callbacks supplied to `start()`. Differential Revision: D77329013
yungsters
force-pushed
the
export-D77329013
branch
from
38049e0 to
e1a879b
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Jun 28, 2025
Summary: Currently, `callback` in `Animated.loop(animation).start(callback)` does not get triggered when calling `stop()` if `animation` uses native driver. This diff implements that functionality. Changelog: [General][Changed] - Stopping an `Animated.loop` for a native animation will now correctly trigger completion callbacks supplied to `start()`. Reviewed By: javache Differential Revision: D77329013
Summary: Pull Request resolved: facebook#52274 Currently, `callback` in `Animated.loop(animation).start(callback)` does not get triggered when calling `stop()` if `animation` uses native driver. This diff implements that functionality. Changelog: [General][Changed] - Stopping an `Animated.loop` for a native animation will now correctly trigger completion callbacks supplied to `start()`. Reviewed By: javache Differential Revision: D77329013
|
This pull request was exported from Phabricator. Differential Revision: D77329013 |
yungsters
force-pushed
the
export-D77329013
branch
from
e1a879b to
887678f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently,
callbackinAnimated.loop(animation).start(callback)does not get triggered when callingstop()ifanimationuses native driver.This diff implements that functionality.
Changelog:
[General][Changed] - Stopping an
Animated.loopfor a native animation will now correctly trigger completion callbacks supplied tostart().Differential Revision: D77329013