feat(iOS): background-size, position and repeat styles #52283
+590
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ios build fix ios nits ios nits nit ios naming null checks
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds support for background size, position and repeat styles. It follows the CSS spec. Currently we default to
background-origin: padding-boxandbackground-clip : border-boxto match the web's behavior. We can introduce these styles later. I have split the PR intro three parts for review. This PR includes iOS only changes. I wanted to introduce one style at a time, but CSS spec is such that size, position and repeat are intertwined.Changelog:
[IOS][ADDED] - Background size, position and repeat styles.
Test Plan:
Merge the JS PR, run
pod installand test RNTester example, it includesBackgroundImageExample. I have also added testcases for syntax parsing in JS.Screen.Recording.2025-06-26.at.10.47.17.AM.mp4