Skip to content

chore: update yylex() signatures in lexer definition files #10472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nuclearpidgeon
Copy link
Contributor

@nuclearpidgeon nuclearpidgeon commented Jun 13, 2025

Fixes GCC 15 compilation issues reported in #10471 . In earlier C standards you can get away with just declaring that it's "a function of some sort", but as of C23 (which GCC 15 enforces by default now), you have to specify the number of arguments: https://gcc.gnu.org/gcc-15/porting_to.html#c23-fn-decls-without-parameters

You have to run flex / the fluentbit build to see it, but the generated signature definition for yylex() is

extern int yylex \
               (YYSTYPE * yylval_param , yyscan_t yyscanner);

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
@nuclearpidgeon
Copy link
Contributor Author

If chore: as a commit prefix isn't appropriate, let me know what would be a better choice

@cosmo0920
Copy link
Contributor

If chore: as a commit prefix isn't appropriate, let me know what would be a better choice

We don't prefer to use chore: in commit messages. Instead, could you split three PRs?
Like:

  • processor_sql: update yylex() signatures in a lexer definition file
  • record_accessor: update yylex() signatures in a lexer definition file
  • stream_processor: update yylex() signatures in a lexer definition file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants