-
Notifications
You must be signed in to change notification settings - Fork 1.7k
in_calyptia_fleet: fix init error mem leaks. #10502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… init. Signed-off-by: Phillip Whelan <phillip.whelan@chronosphere.io>
Signed-off-by: Phillip Whelan <phillip.whelan@chronosphere.io>
Here is a valgrind log:
|
Here is a debug log:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like unit tests are failing - not sure if it is that flake I raised before but we should sort.
I have been working on a draft which should speed up tests but it still needs quite a bit of work: #10503. The other alternative is to rewrite that massive test so multiple checks are done in a single function, while also reducing all the |
Summary
Fix memory leaks in
in_calyptia_fleet
andout_calyptia
that could occur during initialization.Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.