-
Notifications
You must be signed in to change notification settings - Fork 87
Improved navigation, added home button #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
Reviewer's GuideThis PR improves navigation by adding a home button and making the header clickable to return to the report view, refactors event handler setup in popup.js, updates the HTML structure to include the new button and heading ID, and extends CSS with styles for the home button in both light and dark modes. Class diagram for updated popup UI elements and event handlersclassDiagram
class PopupUI {
+Element homeButton
+Element scrumHelperHeading
+showReportView()
}
PopupUI : +addEventListener(homeButton, 'click', showReportView)
PopupUI : +addEventListener(scrumHelperHeading, 'click', showReportView)
PopupUI : +showReportView()
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request improves navigation by adding a home button and making the "Scrum Helper" heading clickable to return to the reports section.
- Added new UI elements (home button and clickable heading) to trigger navigation back to the reports view.
- Removed duplicate variable declarations in popup.js to streamline the code.
- Updated CSS to include styles for the new home button.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/scripts/popup.js | Added event listeners and refactored duplicate declarations for navigation. |
src/popup.html | Updated markup to include the clickable scrum helper heading and home button. |
src/index.css | Added styling for the new home button to support UI consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes - here's some feedback:
- Consider moving the inline font-size style on the home button into your CSS files to keep styling consistent and maintainable.
- Add an accessible label or aria-label to the home button icon so screen readers can identify its purpose.
- You might consolidate the click handlers for
homeButton
andscrumHelperHeading
into a single function or event delegation pattern to reduce duplication.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider moving the inline font-size style on the home button into your CSS files to keep styling consistent and maintainable.
- Add an accessible label or aria-label to the home button icon so screen readers can identify its purpose.
- You might consolidate the click handlers for `homeButton` and `scrumHelperHeading` into a single function or event delegation pattern to reduce duplication.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@hpdang @mariobehling Please take a look whenever you can, I'm open for any and all suggestions. Thank you. |
The implementation works well for me, I really like it. My only comment is that the two icons feel relative big compared to the overall UI. |
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
I have resolved the conflicts, the extension works fine with all the functionalities intact. Thank you! |
📌 Fixes
Fixes #139
📝 Summary of Changes
Added home button to go back to report section, users can also click the scum helper heading to go back to the reports section.
📸 Screenshots / Demo (if UI-related)
✅ Checklist
👀 Reviewer Notes
Add any special notes for the reviewer here
Summary by Sourcery
Restore navigation to the report section by adding a Home button and making the Scrum Helper heading clickable.
New Features:
Bug Fixes: