feat: add support of @testing-library/dom queries #1092
Conversation
talkenson
force-pushed
the
feat/add-dtl
branch
4 times, most recently
from
7195292 to
cddccaf
Compare
There was a problem hiding this comment.
Thoughts I have after taking a look:
-
Let's come up with a better configuration API.
browser.configureDTLisn't a good choice for multiple reasons (you need browser instance to configure, naming feels off, you can't set this globally) -
We need to check an important edge-case: what if users followed through with our docs and uses wdio-testing-library? Then if he updates, tests will be failing, because of duplicate commands. We need to check this
-
We need to check that timeouts for
find*queries are being configured correctly. For example, how timeouts specified in our testplane config, interact with those. If they don't it's an issue, because they should affect testing-library timeouts.
| /** | ||
| * Allows to configure DOM Testing Library | ||
| */ | ||
| configureDTL: typeof configure; |
There was a problem hiding this comment.
Here, we still have configureDTL command
| export { run as runCli } from "./cli"; | ||
| export { Testplane as default } from "./testplane"; | ||
| export { Key } from "@testplane/webdriverio"; | ||
| export * from "./mock"; | ||
|
|
||
| export * as unstable from "./unstable"; | ||
| export * as queries from "./browser/queries"; |
There was a problem hiding this comment.
I think it's better to remove this export, because it exports too much and I don't think items that are being exported will be popular among users. It's better to export as little as possible, because anything that becomes part of public API will need to be supported indefinitely.
No description provided.