-
-
Notifications
You must be signed in to change notification settings - Fork 262
Add os and device attributes to Flutter logs #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
==========================================
+ Coverage 87.60% 87.68% +0.07%
==========================================
Files 280 284 +4
Lines 9208 9267 +59
==========================================
+ Hits 8067 8126 +59
Misses 1141 1141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
eecbbca | 1264.90 ms | 1286.33 ms | 21.43 ms |
2f8f173 | 1280.61 ms | 1292.20 ms | 11.59 ms |
633cf2e | 1257.96 ms | 1275.73 ms | 17.77 ms |
8da6ae0 | 1240.82 ms | 1262.59 ms | 21.77 ms |
3751dbc | 1261.45 ms | 1287.79 ms | 26.34 ms |
cecd4ed | 1232.88 ms | 1250.65 ms | 17.78 ms |
0095354 | 1241.96 ms | 1269.25 ms | 27.29 ms |
8fa3934 | 1252.79 ms | 1272.41 ms | 19.62 ms |
a5031f1 | 1244.14 ms | 1268.79 ms | 24.64 ms |
f0fcbe1 | 1238.08 ms | 1243.44 ms | 5.36 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
eecbbca | 8.15 MiB | 9.10 MiB | 965.26 KiB |
2f8f173 | 8.15 MiB | 9.13 MiB | 1000.39 KiB |
633cf2e | 8.15 MiB | 9.12 MiB | 986.26 KiB |
8da6ae0 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
3751dbc | 8.38 MiB | 9.73 MiB | 1.35 MiB |
cecd4ed | 8.38 MiB | 9.75 MiB | 1.37 MiB |
0095354 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
8fa3934 | 8.09 MiB | 9.07 MiB | 1000.86 KiB |
a5031f1 | 8.32 MiB | 9.50 MiB | 1.18 MiB |
f0fcbe1 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
Previous results on branch: feat/add-os-and-device-attributes-to-logs
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
843e043 | 1260.55 ms | 1268.64 ms | 8.09 ms |
7b903b0 | 1256.06 ms | 1272.84 ms | 16.78 ms |
9547395 | 1250.19 ms | 1251.61 ms | 1.42 ms |
4259a75 | 1258.92 ms | 1280.38 ms | 21.46 ms |
5028a17 | 1264.92 ms | 1275.04 ms | 10.13 ms |
5c21eb1 | 1262.75 ms | 1277.82 ms | 15.07 ms |
4040b91 | 1249.67 ms | 1265.33 ms | 15.66 ms |
b903993 | 1240.39 ms | 1251.12 ms | 10.73 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
843e043 | 7.85 MiB | 9.44 MiB | 1.59 MiB |
7b903b0 | 7.85 MiB | 9.44 MiB | 1.59 MiB |
9547395 | 7.85 MiB | 9.42 MiB | 1.57 MiB |
4259a75 | 7.85 MiB | 9.44 MiB | 1.59 MiB |
5028a17 | 7.85 MiB | 9.42 MiB | 1.57 MiB |
5c21eb1 | 7.85 MiB | 9.42 MiB | 1.57 MiB |
4040b91 | 7.85 MiB | 9.42 MiB | 1.57 MiB |
b903993 | 7.85 MiB | 9.45 MiB | 1.59 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but got a question
dart/lib/src/event_processor/enricher/io_enricher_event_processor.dart
Outdated
Show resolved
Hide resolved
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
deaeece | 347.42 ms | 381.10 ms | 33.68 ms |
a817b8f | 383.02 ms | 445.17 ms | 62.15 ms |
e2d89fc | 323.84 ms | 376.23 ms | 52.39 ms |
202b83f | 357.79 ms | 419.47 ms | 61.68 ms |
a609134 | 350.12 ms | 404.12 ms | 54.00 ms |
c978477 | 347.00 ms | 409.94 ms | 62.94 ms |
886a258 | 436.55 ms | 506.65 ms | 70.09 ms |
e976b2a | 505.31 ms | 567.08 ms | 61.78 ms |
11fb408 | 320.10 ms | 380.24 ms | 60.14 ms |
bd1b990 | 343.82 ms | 410.54 ms | 66.72 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
deaeece | 5.94 MiB | 6.96 MiB | 1.02 MiB |
a817b8f | 6.16 MiB | 7.14 MiB | 1003.22 KiB |
e2d89fc | 6.06 MiB | 7.03 MiB | 989.37 KiB |
202b83f | 6.34 MiB | 7.28 MiB | 966.66 KiB |
a609134 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
c978477 | 6.33 MiB | 7.29 MiB | 987.32 KiB |
886a258 | 6.44 MiB | 7.43 MiB | 1010.45 KiB |
e976b2a | 6.44 MiB | 7.44 MiB | 1016.51 KiB |
11fb408 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
bd1b990 | 6.33 MiB | 7.26 MiB | 950.37 KiB |
Previous results on branch: feat/add-os-and-device-attributes-to-logs
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4259a75 | 492.33 ms | 552.45 ms | 60.12 ms |
4040b91 | 452.50 ms | 525.48 ms | 72.98 ms |
b903993 | 486.13 ms | 500.08 ms | 13.95 ms |
7b903b0 | 457.44 ms | 513.98 ms | 56.54 ms |
843e043 | 526.54 ms | 575.19 ms | 48.64 ms |
9547395 | 488.69 ms | 534.59 ms | 45.89 ms |
5028a17 | 487.22 ms | 568.45 ms | 81.23 ms |
5c21eb1 | 674.37 ms | 739.29 ms | 64.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4259a75 | 6.54 MiB | 7.53 MiB | 1017.88 KiB |
4040b91 | 6.54 MiB | 7.53 MiB | 1017.43 KiB |
b903993 | 6.54 MiB | 7.53 MiB | 1017.75 KiB |
7b903b0 | 6.54 MiB | 7.53 MiB | 1017.84 KiB |
843e043 | 6.54 MiB | 7.53 MiB | 1020.92 KiB |
9547395 | 6.54 MiB | 7.53 MiB | 1017.43 KiB |
5028a17 | 6.54 MiB | 7.53 MiB | 1017.61 KiB |
5c21eb1 | 6.54 MiB | 7.53 MiB | 1017.10 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I'll have a deeper look later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I really like the lifecycle hooks
…m:getsentry/sentry-dart into feat/add-os-and-device-attributes-to-logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
analyze error but LGTM!
@denrase just needs update to changelog then we can merge |
📜 Description
Add os and device attributes to Flutter logs
💡 Motivation and Context
Closes #2966
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps