Skip to content

replay: add sensitive content widget to default masking #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jun 13, 2025

📜 Description

Masks the SensitiveContent widget ootb for replay

TBD: check how we can add backwards compat

💡 Motivation and Context

Closes #2987

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jun 13, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- add sensitive content widget to default masking ([#2989](https://github.com/getsentry/sentry-dart/pull/2989))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 088cf62

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.61%. Comparing base (2cf9161) to head (088cf62).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
flutter/lib/src/sentry_privacy_options.dart 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2989      +/-   ##
==========================================
+ Coverage   87.71%   88.61%   +0.90%     
==========================================
  Files         287       98     -189     
  Lines        9797     3575    -6222     
==========================================
- Hits         8593     3168    -5425     
+ Misses       1204      407     -797     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jul 11, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1266.14 ms 1285.35 ms 19.20 ms
Size 7.86 MiB 9.44 MiB 1.58 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
dbd526b 1244.78 ms 1259.02 ms 14.24 ms
73dca78 1246.65 ms 1265.42 ms 18.76 ms
6ba4675 1223.12 ms 1238.17 ms 15.04 ms
ec78888 1251.37 ms 1269.40 ms 18.04 ms
0fb45d0 1273.24 ms 1286.44 ms 13.19 ms
2cf9161 1248.33 ms 1266.55 ms 18.22 ms
b6c8720 1252.65 ms 1266.61 ms 13.96 ms
93b7728 1247.23 ms 1264.87 ms 17.64 ms
2d34233 1258.19 ms 1268.92 ms 10.73 ms
6f47800 1247.52 ms 1259.37 ms 11.85 ms

App size

Revision Plain With Sentry Diff
dbd526b 7.86 MiB 9.44 MiB 1.58 MiB
73dca78 7.86 MiB 9.44 MiB 1.58 MiB
6ba4675 7.86 MiB 9.44 MiB 1.58 MiB
ec78888 7.86 MiB 9.44 MiB 1.58 MiB
0fb45d0 7.86 MiB 9.44 MiB 1.58 MiB
2cf9161 7.86 MiB 9.44 MiB 1.58 MiB
b6c8720 7.86 MiB 9.44 MiB 1.58 MiB
93b7728 7.86 MiB 9.44 MiB 1.58 MiB
2d34233 7.86 MiB 9.44 MiB 1.58 MiB
6f47800 7.86 MiB 9.44 MiB 1.58 MiB

Previous results on branch: replay/add-sensitive-content

Startup times

Revision Plain With Sentry Diff
5ce2839 1271.55 ms 1281.62 ms 10.07 ms

App size

Revision Plain With Sentry Diff
5ce2839 7.86 MiB 9.44 MiB 1.58 MiB

Copy link
Contributor

github-actions bot commented Jul 11, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 462.73 ms 544.39 ms 81.65 ms
Size 6.54 MiB 7.70 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2d675d 457.92 ms 529.17 ms 71.25 ms
93b7728 475.28 ms 489.13 ms 13.86 ms
640ad0c 466.00 ms 552.67 ms 86.67 ms
79f6b41 469.66 ms 525.90 ms 56.24 ms
575ebaa 478.00 ms 585.76 ms 107.76 ms
dbd526b 504.88 ms 569.02 ms 64.15 ms
73a3c38 478.18 ms 526.62 ms 48.44 ms
aeb02f2 373.84 ms 437.00 ms 63.16 ms
0fb3800 465.64 ms 536.77 ms 71.13 ms
9b99523 456.91 ms 490.55 ms 33.64 ms

App size

Revision Plain With Sentry Diff
e2d675d 6.54 MiB 7.69 MiB 1.15 MiB
93b7728 6.54 MiB 7.69 MiB 1.15 MiB
640ad0c 6.54 MiB 7.69 MiB 1.15 MiB
79f6b41 6.54 MiB 7.69 MiB 1.15 MiB
575ebaa 6.54 MiB 7.69 MiB 1.15 MiB
dbd526b 6.54 MiB 7.69 MiB 1.15 MiB
73a3c38 6.54 MiB 7.69 MiB 1.15 MiB
aeb02f2 6.54 MiB 7.69 MiB 1.15 MiB
0fb3800 6.54 MiB 7.69 MiB 1.15 MiB
9b99523 6.54 MiB 7.69 MiB 1.15 MiB

Previous results on branch: replay/add-sensitive-content

Startup times

Revision Plain With Sentry Diff
5ce2839 462.72 ms 519.61 ms 56.89 ms

App size

Revision Plain With Sentry Diff
5ce2839 6.54 MiB 7.69 MiB 1.15 MiB

Copy link
Contributor

github-actions bot commented Jul 17, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/screenshot/recorder.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SensitiveContent
2 participants