-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(replay): Add _experiments.ignoreMutations
option
#16816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
chargome
reviewed
Jul 7, 2025
mydea
commented
Jul 7, 2025
This option allows to configure a selector list of elements to not capture mutation for.
ignoreMutations
option_experiments.ignoreMutations
option
912ed5c
to
10752f4
Compare
chargome
approved these changes
Jul 7, 2025
bricefriha
reviewed
Jul 7, 2025
Comment on lines
+13
to
+14
const el: HTMLElement | null = node.nodeType === node.ELEMENT_NODE ? (node as HTMLElement) : node.parentElement; | ||
return el; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of declaring the el
constant here?
Is it to make debugging easier? 🙂
Suggested change
const el: HTMLElement | null = node.nodeType === node.ELEMENT_NODE ? (node as HTMLElement) : node.parentElement; | |
return el; | |
return node.nodeType === node.ELEMENT_NODE ? (node as HTMLElement) : node.parentElement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just vendored in from the rrweb implementation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows to configure a selector list of elements to not capture mutation for.
This is under
_experiments
for now:Fixes #16797