✨ feat(scm): add environment infomation to suspect commit prs #93025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
commented
Jun 6, 2025
| title=issue.title, | ||
| subtitle=self.format_comment_subtitle(issue.culprit), | ||
| subtitle=self.format_comment_subtitle(issue.culprit or "unknown culprit"), |
There was a problem hiding this comment.
turns out culprit is falsy
iamrajjoshi
commented
Jun 6, 2025
| return f" Environment: *({environment.name})*" | ||
| except Exception as e: | ||
| # If anything goes wrong, just continue without environment info | ||
| logger.info( |
There was a problem hiding this comment.
not error because i don't think a sentry issue is warranted. this can happen if user doesn't set up environments as well
iamrajjoshi
changed the title
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93025 +/- ##
========================================
Coverage 88.03% 88.04%
========================================
Files 10335 10337 +2
Lines 596828 597013 +185
Branches 23196 23196
========================================
+ Hits 525432 525613 +181
- Misses 70937 70941 +4
Partials 459 459 |
iamrajjoshi
force-pushed
the
raj/env-suspect-commits
branch
from
0353526 to
75e7993
Compare
iamrajjoshi
force-pushed
the
raj/env-suspect-commits
branch
from
b15741d to
a3fcc55
Compare
leeandher
approved these changes
Jun 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds environment information to pr comments.
there isn't a clean way to fetch the environment for a group since there can be many environments associated for a group, but when we open the issue details page, it defaults to opening the
recommended_event(which will also be thelatest_eventfor low frequency groups.this made it an ideal candidate to grab the event for, then fetch its environment and show it in the pr comment. this should address the main pain point since errors in dev will be relatively new and be the recommended event
closes ECO-94