-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(feedback): Split feedback tags into tags+context with collapsable sections #93397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Jun 12, 2025
static/app/components/feedback/feedbackItem/feedbackItemHeader.tsx
Outdated
Show resolved
Hide resolved
dc6e8f4
to
7e729de
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93397 +/- ##
==========================================
- Coverage 88.03% 88.01% -0.03%
==========================================
Files 10350 10287 -63
Lines 598214 592336 -5878
Branches 23227 23026 -201
==========================================
- Hits 526651 521338 -5313
+ Misses 71058 70566 -492
+ Partials 505 432 -73 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Overall changes
I moved around the "Seen By" stuff to save a little vertical space; it used to be directly below the message, now it's in the header
All Sections are collapseable now, saved into local storage
2. Tags & Context changes

I split up Tags & Context, and re-used the components from Issue Details. There's no way to split up Custom tags, but everything will be shown.
Fixes REPLAY-67