feat(open-pr-comments): Golang Language Support #93402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93402 +/- ##
==========================================
+ Coverage 87.99% 88.03% +0.03%
==========================================
Files 10286 10308 +22
Lines 593098 594496 +1398
Branches 23028 23028
==========================================
+ Hits 521896 523349 +1453
+ Misses 70770 70715 -55
Partials 432 432 |
cleptric
reviewed
Jun 12, 2025
Zylphrex
reviewed
Jun 12, 2025
| """ | ||
|
|
||
| # Regular function declarations (including generics) | ||
| function_declaration_regex = r"^@@.*@@[^=]*?\s*func\s+(?P<fnc>\w+)(?:\[[^\]]*\])?\s*\(" |
There was a problem hiding this comment.
Nit: I think you need a \s* within the non captured group for generics because it's legal to have a white space between the function name and the generics.
tests/sentry/integrations/source_code_management/test_language_parsers.py
Outdated
Show resolved
Hide resolved
Zylphrex
approved these changes
Jun 16, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for a Golang for Open PR Comments
Co-authored by Cursor