feat(ui): Flatten discover/eap/span responses #93478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flattens the types into a single type with 900 key/values which is still big, but slightly simpler since it isn't an intersection of all the types.
github-actions
bot
added
the
Scope: Frontend
gggritso
reviewed
Jun 13, 2025
static/app/utils/flatten.tsx
Outdated
There was a problem hiding this comment.
So many things can be flattened! Maybe this would be good in a utils/types/flatten.ts file, to clarify what it's for? No strong opinion on file extension
static/app/views/insights/common/components/tableCells/starredSegmentCell.tsx
Outdated
Show resolved
Hide resolved
gggritso
approved these changes
Jun 16, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
Flattens the types into a single object with 2300 key/values which is still big, but slightly simpler since it isn't an intersection of all the objects with their keys. Reduces the number of instantiations by 100k. before  after 
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Flattens the types into a single object with 2300 key/values which is still big, but slightly simpler since it isn't an intersection of all the objects with their keys. Reduces the number of instantiations by 100k. before  after 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flattens the types into a single object with 2300 key/values which is still big, but slightly simpler since it isn't an intersection of all the objects with their keys. Reduces the number of instantiations by 100k.
before
after
