ref(span-buffer): Add compression #93592
Merged
+129
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
This reverts commit 6bca6f8.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93592 +/- ##
==========================================
+ Coverage 85.57% 88.03% +2.46%
==========================================
Files 10332 10332
Lines 596312 596131 -181
Branches 23163 23121 -42
==========================================
+ Hits 510289 524830 +14541
+ Misses 85567 70808 -14759
- Partials 456 493 +37 |
This reverts commit d124072.
jan-auer
reviewed
Jun 18, 2025
src/sentry/spans/buffer.py
Outdated
Comment on lines
324
to
328
| combined = b"\x00".join(payloads) | ||
|
|
||
| # If compression is disabled, return the combined data as-is | ||
| if self._zstd_compressor is None: | ||
| return combined |
There was a problem hiding this comment.
This might be a problem if we want to roll back. Could we instead write the payloads separately in this case?
There was a problem hiding this comment.
addressed this comment, which also fixes the next one
jan-auer
approved these changes
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies zstd compression (level 0) on the pre-aggregated span trees before they are inserted into Redis. This should reduce the time Redis is blocked on streaming large payload batches.
Since the flusher needs to modify payloads, it de-compresses them on the fly. This change could lead to more CPU consumption and backlogs in the flusher.
Closes STREAM-211