-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(billing): _admin product trial improvements #93644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+259
−248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93644 +/- ##
==========================================
- Coverage 88.01% 86.95% -1.07%
==========================================
Files 10353 10312 -41
Lines 598781 593820 -4961
Branches 23269 23013 -256
==========================================
- Hits 526995 516327 -10668
- Misses 71317 77001 +5684
- Partials 469 492 +23 |
@@ -397,151 +392,36 @@ describe('CustomerOverview', function () { | |||
expect(screen.queryByText('Transactions:')).not.toBeInTheDocument(); | |||
}); | |||
|
|||
it('render product trials for am1 account', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of testing for every single tier, i think it's suffice to show that we render based on subscription state
jarrettscott
approved these changes
Jun 24, 2025
vbro
approved these changes
Jun 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/BIL-948/make-product-trials-better-in-admin
setApiQuery
to auto-refresh product trial states based on management action taken (same for deactivate partner account action)