Skip to content

fix(billing): _admin product trial improvements #93644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 25, 2025

Conversation

isabellaenriquez
Copy link
Member

@isabellaenriquez isabellaenriquez commented Jun 16, 2025

Closes https://linear.app/getsentry/issue/BIL-948/make-product-trials-better-in-admin

  • Surfaces product trial status per category/reserved budget category type (Active / Used / Available)
  • Disables trial management actions based on the current status for that category of product trial (including disabling stop for trials with <1 day left)
  • Makes use of setApiQuery to auto-refresh product trial states based on management action taken (same for deactivate partner account action)
  • Adds tooltips to both enabled and disabled trial management actions to explain what that button does / why it is disabled
  • Minor styling changes

Screenshot 2025-06-24 at 4 30 04 PM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 16, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93644      +/-   ##
==========================================
- Coverage   88.01%   86.95%   -1.07%     
==========================================
  Files       10353    10312      -41     
  Lines      598781   593820    -4961     
  Branches    23269    23013     -256     
==========================================
- Hits       526995   516327   -10668     
- Misses      71317    77001    +5684     
- Partials      469      492      +23     

@@ -397,151 +392,36 @@ describe('CustomerOverview', function () {
expect(screen.queryByText('Transactions:')).not.toBeInTheDocument();
});

it('render product trials for am1 account', function () {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of testing for every single tier, i think it's suffice to show that we render based on subscription state

@isabellaenriquez isabellaenriquez changed the title fix(billing): Disable trial management actions where applicable fix(billing): _admin product trial improvements Jun 24, 2025
@isabellaenriquez isabellaenriquez marked this pull request as ready for review June 24, 2025 20:31
@isabellaenriquez isabellaenriquez requested a review from a team June 24, 2025 20:32
@isabellaenriquez isabellaenriquez merged commit e084752 into master Jun 25, 2025
48 checks passed
@isabellaenriquez isabellaenriquez deleted the isabella/disable-trial-actions branch June 25, 2025 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants