feat(nav): Increase hover preview delay #93707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Jun 17, 2025
| @@ -46,6 +50,7 @@ export function NavContextProvider({children}: {children: React.ReactNode}) { | |||
| NAV_SIDEBAR_COLLAPSED_LOCAL_STORAGE_KEY, | |||
| false | |||
| ); | |||
| const [collapsedNavIsOpen, setCollapsedNavIsOpen] = useState(false); | |||
There was a problem hiding this comment.
Because the preview delay is now less than the collapsed nav open delay, I need to put the open state in context so that I can check it in useActivateNavGroupOnHover() to avoid a bad experience where the contents immediately flip on open
scttcper
approved these changes
Jun 17, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
In an attempt to address concerns about accidental triggers of the hover preview, this increases the preview delay from 150ms to 300ms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to address concerns about accidental triggers of the hover preview, this increases the preview delay from 150ms to 300ms.