ref(trace-items): Pull useGetTraceItemAttributeKeys into hook #93739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
JonasBa
reviewed
Jun 20, 2025
Comment on lines
+20
to
+28
| type TraceItemAttributeKeyOptions = Pick< | ||
| ReturnType<typeof normalizeDateTimeParams>, | ||
| 'end' | 'start' | 'statsPeriod' | 'utc' | ||
| > & { | ||
| attributeType: 'string' | 'number'; | ||
| itemType: TraceItemDataset; | ||
| project?: string[]; | ||
| substringMatch?: string; | ||
| }; |
There was a problem hiding this comment.
How about something like this
Suggested change
| type TraceItemAttributeKeyOptions = Pick< | |
| ReturnType<typeof normalizeDateTimeParams>, | |
| 'end' | 'start' | 'statsPeriod' | 'utc' | |
| > & { | |
| attributeType: 'string' | 'number'; | |
| itemType: TraceItemDataset; | |
| project?: string[]; | |
| substringMatch?: string; | |
| }; | |
| type TraceItemAttributeKeyOptions = { | |
| attributeType: 'string' | 'number'; | |
| itemType: TraceItemDataset; | |
| project?: string[]; | |
| substringMatch?: string; | |
| dateTime: Pick< | |
| ReturnType<typeof normalizeDateTimeParams>, | |
| 'end' | 'start' | 'statsPeriod' | 'utc' | |
| > | |
| }; |
This would allow you to preserve the boundary between the dateTime and the trace item specific options (which seems like two different concepts anyways), at a small cost of the extra key.
There was a problem hiding this comment.
We can't actually do that, this is actually the type of the query string. And since the api is expecting all these keys at the top level, it needs to be like this.
static/app/views/explore/hooks/useGetTraceItemAttributeKeys.tsx
Outdated
Show resolved
Hide resolved
static/app/views/explore/hooks/useGetTraceItemAttributeKeys.tsx
Outdated
Show resolved
Hide resolved
static/app/views/explore/hooks/useGetTraceItemAttributeKeys.tsx
Outdated
Show resolved
Hide resolved
AbhiPrasad
reviewed
Jun 20, 2025
static/app/views/explore/hooks/useGetTraceItemAttributeKeys.tsx
Outdated
Show resolved
Hide resolved
JonasBa
approved these changes
Jun 20, 2025
AbhiPrasad
approved these changes
Jun 20, 2025
Zylphrex
deleted the
txiao/ref/pull-use-get-trace-item-attribute-keys-into-hook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need the
useGetTraceItemAttributeKeyshook in other places so refactoring it so that it can exported.