feat(aci): Set ownership on detector #93745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should update owner on creation and on update
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93745 +/- ##
==========================================
+ Coverage 85.65% 88.03% +2.38%
==========================================
Files 10331 10331
Lines 596456 596402 -54
Branches 23169 23140 -29
==========================================
+ Hits 510888 525061 +14173
+ Misses 85109 70890 -14219
+ Partials 459 451 -8 |
malwilley
reviewed
Jun 17, 2025
| @@ -33,6 +34,7 @@ class BaseDetectorTypeValidator(CamelSnakeSerializer): | |||
| ) | |||
| type = serializers.CharField() | |||
| config = serializers.JSONField(default={}) | |||
| owner = ActorField(required=False, allow_null=True) | |||
There was a problem hiding this comment.
Should it be possible to create a detector without an owner? Right now in the UI we assume that detectors without an owner are created by Sentry
malwilley
approved these changes
Jun 17, 2025
| @@ -60,6 +62,22 @@ def data_conditions(self) -> BaseDataConditionValidator: | |||
| def update(self, instance: Detector, validated_data: dict[str, Any]): | |||
| instance.name = validated_data.get("name", instance.name) | |||
| instance.type = validated_data.get("detector_type", instance.group_type).slug | |||
|
|
|||
| # Handle owner field update | |||
| if "owner" in validated_data: | |||
There was a problem hiding this comment.
Is this initial if statement necessary?
There was a problem hiding this comment.
yes because they could omit it entirely from a partial update
# Conflicts: # src/sentry/workflow_engine/endpoints/validators/base/detector.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should update owner on creation and on update