fix: Add ensure assignment when swapping seats from onboarding to auto created #93751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
brendanhsentry
approved these changes
Jun 17, 2025
wedamija
reviewed
Jun 17, 2025
| @@ -344,7 +344,7 @@ def update_project_uptime_subscription( | |||
| case ObjectStatus.DISABLED: | |||
| disable_uptime_detector(detector) | |||
| case ObjectStatus.ACTIVE: | |||
| enable_uptime_detector(detector) | |||
| enable_uptime_detector(detector, ensure_assignment=True) | |||
There was a problem hiding this comment.
Should we pass ensure_assignment as a parameter to update_project_uptime_subscription, so that we only set it when we're going from onboarding -> active?
Right now, we're going to be forcing assignment whenever we update an uptime monitor at all
ajay-sentry
added a commit
that referenced
this pull request
Jun 17, 2025
We don't want to assign seats everytime, namely for the following case: - Monitor already enabled and has seat assigned - Status "active" passed in to monitor endpoint - Endpoint "ensures" seat assignment and creates a new seat I'm unsure if the assignment logic is smart enough to not create this new seat, so its probably better to be safe than sorry. Amends #93751 <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…o created (#93751) Currently when an uptime is converted from onboarding to auto created, we aren't actually creating a seat assignment. When we create this seat we should be "ensuring a seat gets assigned," which requires passing in the additional parameter. <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
We don't want to assign seats everytime, namely for the following case: - Monitor already enabled and has seat assigned - Status "active" passed in to monitor endpoint - Endpoint "ensures" seat assignment and creates a new seat I'm unsure if the assignment logic is smart enough to not create this new seat, so its probably better to be safe than sorry. Amends #93751 <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when an uptime is converted from onboarding to auto created, we aren't actually creating a seat assignment. When we create this seat we should be "ensuring a seat gets assigned," which requires passing in the additional parameter.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.