-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(devservices): Add tracing mode #93759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ File not in storage
Additional details and impacted files@@ Coverage Diff @@
## master #93759 +/- ##
===========================================
+ Coverage 53.06% 88.07% +35.00%
===========================================
Files 10334 10336 +2
Lines 596995 596699 -296
Branches 23222 23092 -130
===========================================
+ Hits 316824 525543 +208719
+ Misses 279667 70700 -208967
+ Partials 504 456 -48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, but otherwise LGTM
We should run the item versions of the consumers instead, not the spans ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @shruthilayaj says, but with subscription-results-eap-items
.
@phacops What does this mean? I added subscription-results-eap-items, is that what you're referring to? |
Yes. |
@phacops @shruthilayaj I've changed this mode from |
Addressed comments, can follow up if necessary after merging
This adds mode for all things tracing. This encompasses transactions/metrics/spans.
Taken from
sentry/src/sentry/runner/commands/devserver.py
Line 370 in feeaf39