Skip to content

feat(devservices): Add tracing mode #93759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 20, 2025
Merged

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Jun 17, 2025

This adds mode for all things tracing. This encompasses transactions/metrics/spans.

Taken from

if settings.SENTRY_USE_SPANS_BUFFER:

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❌ File not in storage

No result to display due to the CLI not being able to find the file.
Please ensure the file contains junit in the name and automated file search is enabled,
or the desired file specified by the file and search_dir arguments of the CLI.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93759       +/-   ##
===========================================
+ Coverage   53.06%   88.07%   +35.00%     
===========================================
  Files       10334    10336        +2     
  Lines      596995   596699      -296     
  Branches    23222    23092      -130     
===========================================
+ Hits       316824   525543   +208719     
+ Misses     279667    70700   -208967     
+ Partials      504      456       -48     

Copy link
Member

@shruthilayaj shruthilayaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, but otherwise LGTM

@phacops
Copy link
Contributor

phacops commented Jun 18, 2025

We should run the item versions of the consumers instead, not the spans ones.

Copy link
Contributor

@phacops phacops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @shruthilayaj says, but with subscription-results-eap-items.

@hubertdeng123
Copy link
Member Author

We should run the item versions of the consumers instead, not the spans ones.

@phacops What does this mean? I added subscription-results-eap-items, is that what you're referring to?

@phacops
Copy link
Contributor

phacops commented Jun 18, 2025

@phacops What does this mean? I added subscription-results-eap-items, is that what you're referring to?

Yes.

@hubertdeng123 hubertdeng123 changed the title feat(devservices): Add spans mode feat(devservices): Add tracing mode Jun 18, 2025
@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Jun 18, 2025

@phacops @shruthilayaj I've changed this mode from spans to tracing to encompass transactions, spans, and metrics now since I've heard feedback that it might be more useful this way. Could you double check to see if I'm missing anything?

@hubertdeng123 hubertdeng123 requested a review from phacops June 20, 2025 16:59
@hubertdeng123 hubertdeng123 dismissed phacops’s stale review June 20, 2025 17:49

Addressed comments, can follow up if necessary after merging

@hubertdeng123 hubertdeng123 merged commit 78d346e into master Jun 20, 2025
62 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/add-spans-mode branch June 20, 2025 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants