-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(preprod): Add analysis_file_id field #93826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR has a migration; here is the generated SQL for for --
-- Add field analysis_file_id to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "analysis_file_id" bigint NULL;
CREATE INDEX CONCURRENTLY "sentry_preprodartifact_analysis_file_id_5ed6a408" ON "sentry_preprodartifact" ("analysis_file_id"); |
1b96dce
to
11a2874
Compare
src/sentry/preprod/models.py
Outdated
@@ -113,6 +113,9 @@ def as_choices(cls): | |||
|
|||
commit = FlexibleForeignKey("sentry.Commit", null=True, on_delete=models.SET_NULL) | |||
|
|||
# Nullable in case the file upload fails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Size analysis also won't necessarily run for every customer based on quotas.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93826 +/- ##
==========================================
+ Coverage 85.65% 88.02% +2.37%
==========================================
Files 10331 10332 +1
Lines 596435 596405 -30
Branches 23161 23161
==========================================
+ Hits 510869 524983 +14114
+ Misses 85107 70963 -14144
Partials 459 459 |
Add this new field so that we have a reference in the preprod table for which file in filestore is the analysis (treemap)
Add this new field so that we have a reference in the preprod table for which file in filestore is the analysis (treemap)