Skip to content

feat:(search-bar): Hide asterisk character for contains ops #93848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nsdeschenes
Copy link
Contributor

This PR updates the function that formats values being rendered in the search bar so that they won't render the asterisks when all values are considered to be wildcard'ed values.

Example:

Screenshot 2025-06-18 at 15 13 50

@nsdeschenes nsdeschenes requested a review from malwilley June 18, 2025 19:22
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 18, 2025
@nsdeschenes nsdeschenes marked this pull request as ready for review June 18, 2025 19:26
@nsdeschenes nsdeschenes force-pushed the nd/exp-19/feat-hide-asterisk-character-for-contains-ops branch from cb3301d to 953ed34 Compare June 25, 2025 10:15
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93848      +/-   ##
==========================================
- Coverage   86.84%   82.86%   -3.98%     
==========================================
  Files       10364    10364              
  Lines      599674   599671       -3     
  Branches    23303    23302       -1     
==========================================
- Hits       520772   496922   -23850     
- Misses      78433   102280   +23847     
  Partials      469      469              

@nsdeschenes nsdeschenes merged commit f355d0e into master Jun 25, 2025
45 checks passed
@nsdeschenes nsdeschenes deleted the nd/exp-19/feat-hide-asterisk-character-for-contains-ops branch June 25, 2025 10:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants