-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat:(search-bar): Hide asterisk character for contains ops #93848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nsdeschenes
merged 6 commits into
master
from
nd/exp-19/feat-hide-asterisk-character-for-contains-ops
Jun 25, 2025
Merged
feat:(search-bar): Hide asterisk character for contains ops #93848
nsdeschenes
merged 6 commits into
master
from
nd/exp-19/feat-hide-asterisk-character-for-contains-ops
Jun 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malwilley
reviewed
Jun 18, 2025
static/app/components/searchQueryBuilder/tokens/filter/utils.tsx
Outdated
Show resolved
Hide resolved
static/app/components/searchQueryBuilder/tokens/filter/utils.tsx
Outdated
Show resolved
Hide resolved
b46aef8
to
b4e4da1
Compare
malwilley
approved these changes
Jun 24, 2025
…operator is active
cb3301d
to
953ed34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93848 +/- ##
==========================================
- Coverage 86.84% 82.86% -3.98%
==========================================
Files 10364 10364
Lines 599674 599671 -3
Branches 23303 23302 -1
==========================================
- Hits 520772 496922 -23850
- Misses 78433 102280 +23847
Partials 469 469 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the function that formats values being rendered in the search bar so that they won't render the asterisks when all values are considered to be wildcard'ed values.
Example: