profiling: fix differential flamegraph colors #93853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
commented
Jun 18, 2025
| @@ -360,8 +360,8 @@ export const makeLightChonkFlamegraphTheme = ( | |||
| // Preset colors | |||
| FRAME_APPLICATION_COLOR: hexToColorChannels(theme.colors.blue400, 0.4), | |||
| FRAME_SYSTEM_COLOR: hexToColorChannels(theme.colors.red400, 0.3), | |||
| DIFFERENTIAL_DECREASE: hexToColorChannels(theme.colors.yellow200, 1), | |||
| DIFFERENTIAL_INCREASE: hexToColorChannels(theme.colors.red300, 1), | |||
| DIFFERENTIAL_DECREASE: hexToColorChannels(theme.colors.blue400, 0.6), | |||
There was a problem hiding this comment.
The chonk colors are too strong, and the regular scale is either too strong or too dimmed out to be able to see the colors. Given that a lot of the colors here are custom, I think it's fine to do this, but at some point in the future, it'd be great to either adopt the chart scale across profiling, or have a dedicated flamegraph scale
Zylphrex
approved these changes
Jun 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93853 +/- ##
==========================================
- Coverage 88.03% 84.19% -3.85%
==========================================
Files 10335 10333 -2
Lines 596759 596737 -22
Branches 23194 23194
==========================================
- Hits 525355 502413 -22942
- Misses 70945 93865 +22920
Partials 459 459 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DE-141