Skip to content

Refactor dynamic sampling rule ID assignment using ORM query #93854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Refactor dynamic sampling rule ID assignment using ORM query #93854

wants to merge 2 commits into from

Conversation

oioki
Copy link
Member

@oioki oioki commented Jun 18, 2025

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 18, 2025
@oioki oioki requested a review from a team June 18, 2025 20:07
@constantinius
Copy link
Contributor

This could cause a race condition between the back and forth of the DB and the API. I think it should be possible to solve this via the models/queryset functionality. Let me take a look.

constantinius
constantinius requested changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@constantinius constantinius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

@constantinius constantinius mentioned this pull request Jun 23, 2025
Merged
@oioki oioki closed this Jun 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@constantinius constantinius

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oioki @constantinius @cursoragent