Skip to content

fix(dashboards): Remove waiting for animation on chart zoom #93909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

narsaynorath
Copy link
Member

This is causing zooming issues where the finish handler isn't triggering and flushing the queued up time range changes (i.e. updating the URL params so the remaining charts and page filters can update).

We've decided to immediately trigger the state changes because we know the chart zoom callback consistently triggers

This is causing zooming issues where the finish handler isn't triggering
and flushing the queued up time range changes (i.e. updating the URL
params so the remaining charts and page filters can update).

We've decided to immediately trigger the state changes because we know
the chart zoom callback consistently triggers
@narsaynorath narsaynorath requested a review from a team as a code owner June 19, 2025 15:17
@narsaynorath narsaynorath requested a review from a team June 19, 2025 15:17
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 19, 2025
Copy link
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 🚮

@narsaynorath narsaynorath merged commit 2102d7b into master Jun 19, 2025
46 checks passed
@narsaynorath narsaynorath deleted the nar/fix/dashboards-chartzoom-remove-waiting-for-animation branch June 19, 2025 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants