Skip to content

feat(replay): Add warning banners for Jetpack Compose 1.8+ #93916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 19, 2025

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jun 19, 2025

This displays warning banners on the replay list and details when:

  • any replay has sdk name sentry.java.android
  • sdk version is < 8.14.0
  • on replay details we also check to see if it is a video replay

image

image

This displays warning banners on the replay list and details when:

- any replay has sdk name `sentry.java.android`
- sdk version is < 8.14.0
- on replay details we also check to see if it is a video replay
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 19, 2025
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93916   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files       10338    10338           
  Lines      597170   597170           
  Branches    23203    23203           
=======================================
  Hits       525730   525730           
  Misses      70976    70976           
  Partials      464      464           

@billyvg billyvg marked this pull request as ready for review June 19, 2025 20:12
@billyvg billyvg requested a review from a team as a code owner June 19, 2025 20:12
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock the merge but we need to wait until GHSA-7cjh-xx4r-qh3f is released

@billyvg billyvg merged commit 633f26d into master Jun 19, 2025
46 checks passed
@billyvg billyvg deleted the billy/feat-replay-add-jetpack-compose-notice branch June 19, 2025 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants