Skip to content

feat(dashboards): Backfill positions when requested in starred endpoint #93920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

narsaynorath
Copy link
Member

If any of the dashboards that are requested have position unset, then take the order and commit them so the position is backfilled

There shouldn't be a scenario where there are positioned dashboards and unpositioned dashboards, but the test case shows that it can be handled. This is meant to fill in data for a user's first visit. When we see that the data is all backfilled we can remove the code related to this check.

@narsaynorath narsaynorath requested a review from a team June 19, 2025 19:42
@narsaynorath narsaynorath requested a review from a team as a code owner June 19, 2025 19:42
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 19, 2025
@narsaynorath narsaynorath enabled auto-merge (squash) June 19, 2025 20:00
@narsaynorath narsaynorath merged commit 315b438 into master Jun 19, 2025
65 checks passed
@narsaynorath narsaynorath deleted the narsaynorath/dain-542-address-backfilldefaults-for-position-data branch June 19, 2025 20:01
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93920   +/-   ##
=======================================
  Coverage   88.03%   88.04%           
=======================================
  Files       10340    10340           
  Lines      597264   597277   +13     
  Branches    23207    23207           
=======================================
+ Hits       525831   525848   +17     
+ Misses      70929    70925    -4     
  Partials      504      504           

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants