Skip to content

chore(seer): optimize scanner rate limiting #93928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025
Merged

Conversation

roaga
Copy link
Member

@roaga roaga commented Jun 20, 2025

  • Bump scanner rate limit to 2500 per hour. Since we now scan existing issues as well, and since we double-count in slack alerts, we're going to be hitting the rate limit a lot more. This is still respectable for budgets, capping at $7.50.
  • Only increment and check rate limit after we pass the quota check and are about to start a scanner task. Right now we're logging rate limit exceeded errors for customers without any quota.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:160664 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93928   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files       10342    10342           
  Lines      597312   597362   +50     
  Branches    23212    23212           
=======================================
+ Hits       525842   525890   +48     
- Misses      70965    70967    +2     
  Partials      505      505           

@roaga roaga marked this pull request as ready for review June 20, 2025 13:26
@roaga roaga requested a review from a team as a code owner June 20, 2025 13:26
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding a test?

@roaga roaga merged commit bd537e0 into master Jun 20, 2025
63 checks passed
@roaga roaga deleted the seer/rate-limit-fixes branch June 20, 2025 14:13
Copy link

sentry-io bot commented Jun 29, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants